Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance applyOncePerOrder voucher behaviour description #1460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zedzior
Copy link
Member

@zedzior zedzior commented Feb 3, 2025

This PR clarifies, that applyOncePerOrder voucher reduces the value of a single unit, and not the entire line

@zedzior zedzior self-assigned this Feb 3, 2025
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 0:04am

@@ -24,6 +24,7 @@ We can also distinguish vouchers by their value type:
- `PERCENTAGE`: reduces the price by a specified percentage value.

By setting `Voucher.applyOncePerOrder`, there is an option to apply the discount only to the cheapest eligible product.
The discount reduces the value of a single unit, not the entire line.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The discount reduces the value of a single unit, not the entire line.
The discount reduces the price of a single quantity of the cheapest product.

Maybe something like this ? ☝️ I don't think that we need to explicitly say, that this voucher is not applied on entire line. I mean, this is already clear from first part of the sentence.
I've also changed the unit into quantity, as we are using quantity in the OrderLine, CheckoutLine, so I assumed that this would better fit here.
But this is only the suggestions 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion. The purpose of this sentence is to emphasize that the this voucher is not applied to the entire line (like the all other line-level discounts), so I would keep it. I used "single unit" as I am not sure if "single quantity" phrase exists in english. Please note, that the info, that it is applied to the cheapest product is contained in the sentence right before. This my rationale, let's wait for other reviewers and let them decide what fits here better.

Copy link
Member

@IKarbowiak IKarbowiak Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:
The discount applies to a single unit of the product, not the entire order line.

@korycins korycins requested a review from a team February 4, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants