Fix open with cmd key #5381
Merged
Fix open with cmd key #5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ec2cb3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
src/components/Datagrid/Datagrid.tsx
Outdated
| @@ -530,16 +530,16 @@ export const Datagrid: React.FC<DatagridProps> = ({ | |||
| aria-hidden={true} | |||
| onWheelCapture={hideLinkAndShowAfterDelay} | |||
| onClick={e => { | |||
There was a problem hiding this comment.
move this handler to the separate function and a write test where you pass event and you make assertion what url is being passed to the "navigate" + add comment in the test that navigate uses browser history which handles /dashbaord/ vs /
poulch
force-pushed
the
bck-1295-fix-cmd
branch
from
e10d9f5 to
16ae2f5
Compare
andrzejewsky
approved these changes
Jan 31, 2025
Cloud11PL
approved these changes
Jan 31, 2025
poulch
added a commit
that referenced
this pull request
Jan 31, 2025
* Fix open with cmd key * Add changeset * Log href * Remove console.log and use default action * Add tests * Change mocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the change