Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align modals and fix infinity screen on large desktops #5373

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

poulch
Copy link
Member

@poulch poulch commented Jan 27, 2025

Scope of the change

All modals have similar height. You can use modal with infinity scroll on large desktop.

Screenshot 2025-01-27 at 14 34 03

Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 380973e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5373 January 27, 2025 13:52 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5373 January 27, 2025 13:57 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5373 January 27, 2025 14:41 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5373 January 29, 2025 11:24 Destroyed
@poulch poulch requested a review from a team as a code owner January 29, 2025 12:17
@github-actions github-actions bot temporarily deployed to pr-5373 January 29, 2025 12:21 Destroyed
@poulch poulch merged commit 1b8d964 into main Jan 31, 2025
15 checks passed
@poulch poulch deleted the bck-1429-fix-moda-scroll branch January 31, 2025 11:19
poulch added a commit that referenced this pull request Jan 31, 2025
* Intorduce InfinityScroll component

* Remove not used styles, add style for scrollArea

* Use a new InfinityScroll component

* Add changeset

* Remove loaders

---------

Co-authored-by: Patryk Andrzejewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants