Bump react to 18 #5359

poulch · 2025-01-17T18:26:44Z

Scope of the change

changeset-bot · 2025-01-17T18:26:48Z

⚠️ No Changeset found

Latest commit: b15b78e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-01-17T18:29:41Z

Differences Found

✅ No packages or licenses were added.

Summary

Expand

License Name	Package Count	Packages
0BSD	1	Packages tslib
BlueOak-1.0.0	1	Packages path-scurry
CC0-1.0	1	Packages type-fest
MIT/X11	1	Packages nub
MPL-1.1	1	Packages harmony-reflect
MPL-2.0	1	Packages dompurify
Public Domain	1	Packages jsonify
Python-2.0	1	Packages argparse
WTFPL	1	Packages opener
CC-BY-4.0	2	Packages @saleor/macaw-ui caniuse-lite
<<missing>>	3	Packages busboy saleor-dashboard streamsearch
BSD-2-Clause	24	Packages @typescript-eslint/parser @typescript-eslint/typescript-estree browser-process-hrtime css-select css-what domelementtype domhandler domutils dotenv dotenv-expand entities escodegen eslint-scope espree esprima esrecurse estraverse esutils nth-check stringify-object And 4 more...
BSD-3-Clause	45	Packages @humanwhocodes/object-schema @sentry/cli @sentry/cli-darwin @sentry/cli-linux-arm @sentry/cli-linux-arm64 @sentry/cli-linux-i686 @sentry/cli-linux-x64 @sentry/cli-win32-i686 @sentry/cli-win32-x64 @sinonjs/commons @sinonjs/fake-timers abab asn1js babel-plugin-istanbul charenc chroma-js crypt diff esquery exenv And 25 more...
Apache-2.0	46	Packages @ampproject/remapping @editorjs/editorjs @humanwhocodes/config-array @humanwhocodes/module-importer @opentelemetry/api @opentelemetry/semantic-conventions @playwright/test @swc/core @swc/core-darwin-arm64 @swc/core-darwin-x64 @swc/core-linux-arm-gnueabihf @swc/core-linux-arm64-gnu @swc/core-linux-arm64-musl @swc/core-linux-x64-gnu @swc/core-linux-x64-musl @swc/core-win32-arm64-msvc @swc/core-win32-ia32-msvc @swc/core-win32-x64-msvc @swc/counter aria-query And 26 more...
ISC	50	Packages @esbuild-plugins/node-globals-polyfill @istanbuljs/load-nyc-config @saleor/app-sdk anymatch boolbase browser-stdout cli-width cliui electron-to-chromium fastq flatted fs.realpath get-caller-file get-own-enumerable-property-symbols glob glob-parent graceful-fs inflight inherits ini And 30 more...
MIT	1123	Packages @adobe/css-tools @apollo/client @ardatan/relay-compiler @ardatan/sync-fetch @babel/code-frame @babel/compat-data @babel/core @babel/generator @babel/helper-annotate-as-pure @babel/helper-compilation-targets @babel/helper-create-class-features-plugin @babel/helper-member-expression-to-functions @babel/helper-module-imports @babel/helper-module-transforms @babel/helper-optimise-call-expression @babel/helper-plugin-utils @babel/helper-replace-supers @babel/helper-simple-access @babel/helper-skip-transparent-expression-wrappers @babel/helper-string-parser And 1103 more...

witoszekdev

I think we should:

get rid of ts-ignore in favor of ts-expect-error + add description why it's needed?
don't use import * as React from "react"; since we're importing only selected functions in rest of our codebase
replace ReactChildren type with ReactNode if it makes sense - I don't think we should limit what children should be passed if we're not explicitly requiring them to be React components
replace macaw with stable version
change that ESLint config as they suggested in docs

witoszekdev · 2025-01-29T11:36:20Z

.eslintrc.json

@@ -91,6 +91,7 @@
    ],
    // Decided to turn off:
    "react/prop-types": "off",
+    "react/react-in-jsx-scope": "off",


suggestion: according to react eslint plugin docs, we should instead extend react/jsx-runtime config:

If you are using the new JSX transform from React 17, you should disable this rule by extending react/jsx-runtime in your eslint config (add "plugin:react/jsx-runtime" to "extends").

witoszekdev · 2025-01-29T11:37:12Z

package-lock.json

@@ -30,7 +30,7 @@
        "@material-ui/styles": "^4.11.4",
        "@reach/auto-id": "^0.16.0",
        "@saleor/macaw-ui": "npm:@saleor/[email protected]",
-        "@saleor/macaw-ui-next": "npm:@saleor/macaw-ui@1.1.15",
+        "@saleor/macaw-ui-next": "npm:@saleor/macaw-ui@0.0.0-pr-20250127234423",


issue: is this a mistake? if we have unreleased changes we should probably release new macaw version

witoszekdev · 2025-01-29T11:40:54Z

src/apps/components/InstalledAppListRow/InstalledAppListRow.test.tsx

+    {/* eslint-disable-next-line @typescript-eslint/ban-ts-comment */}
+    {/* @ts-ignore */}


suggestion: we should use @ts-expect-error instead of @ts-ignore, because if for some reason we don't have TypeScript error anymore it will be shown as error so that we can remove this comment. You also don't need to disable ESLint rule for that (probably)

witoszekdev · 2025-01-29T11:41:27Z

src/channels/components/AssignmentList/AssignmentList.tsx

+              {/* eslint-disable-next-line @typescript-eslint/ban-ts-comment */}
+              {/* @ts-ignore */}


suggestion: same here let's use @ts-expect-error

witoszekdev · 2025-01-29T11:41:42Z

src/channels/components/AssignmentList/Item.tsx

+            // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+            // @ts-ignore


@ts-expect-error

witoszekdev · 2025-01-29T11:46:29Z

src/components/AddressEdit/AddressEdit.tsx

@@ -6,7 +6,7 @@ import { getFormErrors } from "@dashboard/utils/errors";
 import { TextField } from "@material-ui/core";
 import { makeStyles } from "@saleor/macaw-ui";
 import { Option } from "@saleor/macaw-ui-next";
-import React from "react";
+import * as React from "react";


question: why do we need this import, can we get rid of it?

poulch and others added 21 commits December 6, 2024 12:31

Bump react version

fd0cec7

New root rendering

edf1f95

jsx react

ebff1eb

migrate from React.FC

1ed61fa

Remove react import from src

60e6c74

add-test

6886077

Disable eslint rule react-in-jsx-scope

f88e8d6

Fixes for check types

dc4c131

fix tests

adee522

Use legacy render

42e3406

Use createRoot

d65d7c3

Merge branch 'main' into bump-react

2f2989c

Merge branch 'main' into bump-react

f974500

Merge branch 'main' into bump-react

c8dcea7

Fix react import

93b95ab

Bump macaw wth dropdowns fix

323181a

Bump macaw

2f5a33b

Bump macaw

e6ed25f

Bump macaw and fix rule form

ee28eb4

Merge branch 'main' into bump-react

53574bb

Bump macaw

0023fb9

poulch added the run pw-e2e label Jan 17, 2025

poulch requested review from a team as code owners January 17, 2025 18:26

poulch requested review from witoszekdev and krzysztofzuraw January 17, 2025 18:26

github-actions bot temporarily deployed to pr-5359 January 17, 2025 18:31 Destroyed

poulch changed the title ~~Bump react to 19~~ Bump react to 18 Jan 18, 2025

github-actions bot temporarily deployed to pr-5359 January 18, 2025 11:51 Destroyed

github-actions bot temporarily deployed to pr-5359 January 18, 2025 12:15 Destroyed

github-actions bot temporarily deployed to pr-5359 January 18, 2025 14:18 Destroyed

github-actions bot temporarily deployed to pr-5359 January 18, 2025 15:56 Destroyed

Fix for test 194 and 198

b0f79ac

github-actions bot temporarily deployed to pr-5359 January 18, 2025 20:30 Destroyed

Fix for test 217

f52fca1

github-actions bot temporarily deployed to pr-5359 January 18, 2025 22:28 Destroyed

github-actions bot temporarily deployed to pr-5359 January 20, 2025 20:37 Destroyed

bump macaw

eebe3f0

github-actions bot temporarily deployed to pr-5359 January 20, 2025 23:47 Destroyed

github-actions bot temporarily deployed to pr-5359 January 21, 2025 03:07 Destroyed

bump macaw with debug

f005be3

github-actions bot temporarily deployed to pr-5359 January 22, 2025 00:18 Destroyed

poulch added 2 commits January 22, 2025 10:40

bump macaw with debug v2

2b27687

fix rich text editor save function

a3bd2bc

github-actions bot temporarily deployed to pr-5359 January 22, 2025 09:42 Destroyed

Merge branch 'main' into bump-react-to-19

24fcdfe

github-actions bot temporarily deployed to pr-5359 January 27, 2025 08:44 Destroyed

github-actions bot temporarily deployed to pr-5359 January 27, 2025 09:22 Destroyed

github-actions bot temporarily deployed to pr-5359 January 27, 2025 09:58 Destroyed

github-actions bot temporarily deployed to pr-5359 January 27, 2025 10:28 Destroyed

github-actions bot temporarily deployed to pr-5359 January 27, 2025 11:16 Destroyed

bump macaw

7336359

github-actions bot temporarily deployed to pr-5359 January 27, 2025 23:49 Destroyed

Update navigation and order SALEOR_217 test

b15b78e

github-actions bot temporarily deployed to pr-5359 January 28, 2025 08:50 Destroyed

github-actions bot temporarily deployed to pr-5359 January 28, 2025 09:29 Destroyed

github-actions bot deployed to pr-5359 January 28, 2025 11:55 View deployment

witoszekdev requested changes Jan 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump react to 18 #5359

Bump react to 18 #5359

poulch commented Jan 17, 2025

changeset-bot bot commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025

witoszekdev left a comment •

edited

Loading

witoszekdev Jan 29, 2025

witoszekdev Jan 29, 2025

witoszekdev Jan 29, 2025

witoszekdev Jan 29, 2025

witoszekdev Jan 29, 2025

witoszekdev Jan 29, 2025

		{/* eslint-disable-next-line @typescript-eslint/ban-ts-comment */}
		{/* @ts-ignore */}

		// eslint-disable-next-line @typescript-eslint/ban-ts-comment
		// @ts-ignore

Bump react to 18 #5359

Are you sure you want to change the base?

Bump react to 18 #5359

Conversation

poulch commented Jan 17, 2025

Scope of the change

changeset-bot bot commented Jan 17, 2025 • edited Loading

⚠️ No Changeset found

github-actions bot commented Jan 17, 2025

Differences Found

Summary

witoszekdev left a comment • edited Loading

Choose a reason for hiding this comment

witoszekdev Jan 29, 2025

Choose a reason for hiding this comment

witoszekdev Jan 29, 2025

Choose a reason for hiding this comment

witoszekdev Jan 29, 2025

Choose a reason for hiding this comment

witoszekdev Jan 29, 2025

Choose a reason for hiding this comment

witoszekdev Jan 29, 2025

Choose a reason for hiding this comment

witoszekdev Jan 29, 2025

Choose a reason for hiding this comment

changeset-bot bot commented Jan 17, 2025 •

edited

Loading

witoszekdev left a comment •

edited

Loading