Remove middlewares

saleor · witoszekdev · Feb 3, 2025 · Jan 28, 2025 · Jan 28, 2025 · Jan 28, 2025
commit a70c440c449ad9f3989ff5133b796eae39358568
@@ -126,11 +126,6 @@
       "import": "./settings-manager/index.mjs",
       "require": "./settings-manager/index.js"
     },
-    "./middleware": {
-      "types": "./middleware/index.d.ts",
-      "import": "./middleware/index.mjs",
-      "require": "./middleware/index.js"
-    },
     "./urls": {
       "types": "./urls.d.ts",
       "import": "./urls.mjs",

@@ -18,9 +18,6 @@ export default defineConfig({
     "handlers/shared/index": "src/handlers/shared/index.ts",
     "handlers/actions/index": "src/handlers/actions/index.ts",
 
-    // Deprecated
-    "middleware/index": "src/middleware/index.ts",
-
     // Mapped exports
     "handlers/next/index": "src/handlers/platforms/next/index.ts",
   },

diff --git a/src/handlers/actions/register-action-handler.ts b/src/handlers/actions/register-action-handler.ts
 /* eslint-disable max-classes-per-file */
 import { APL, AuthData } from "@/APL";
 import { SALEOR_API_URL_HEADER, SALEOR_DOMAIN_HEADER } from "@/const";
 import { createDebug } from "@/debug";
 import { fetchRemoteJwks } from "@/fetch-remote-jwks";
 import { getAppId } from "@/get-app-id";
  private runPreChecks(): ActionHandlerResult | null {
    const checksToRun = [
      this.adapterMiddleware.withMethod(["POST"]),
      this.adapterMiddleware.withSaleorDomainPresent(),
    ];

    for (const check of checksToRun) {
diff --git a/src/handlers/platforms/next/create-app-register-handler.test.ts b/src/handlers/platforms/next/create-app-register-handler.test.ts

      const expectedAuthData: AuthData = {
        token: "mock-auth-token",
        domain: "https://mock-saleor-domain.saleor.cloud/",
        saleorApiUrl: "https://mock-saleor-domain.saleor.cloud/graphql/",
        jwks: mockJwksValue,
        appId: mockAppId,

      const expectedAuthData: AuthData = {
        token: "mock-auth-token",
        domain: "https://mock-saleor-domain.saleor.cloud/",
        saleorApiUrl: "https://mock-saleor-domain.saleor.cloud/graphql/",
        jwks: mockJwksValue,
        appId: mockAppId,
diff --git a/src/handlers/platforms/next/saleor-webhooks/saleor-async-webhook.test.ts b/src/handlers/platforms/next/saleor-webhooks/saleor-async-webhook.test.ts
        payload: { data: "test_payload" },
        schemaVersion: 3.19,
        authData: {
          domain: "example.com",
          token: "token",
          jwks: "",
          saleorApiUrl: "https://example.com/graphql/",
diff --git a/src/handlers/platforms/next/saleor-webhooks/saleor-sync-webhook.test.ts b/src/handlers/platforms/next/saleor-webhooks/saleor-sync-webhook.test.ts
        payload: { data: "test_payload" },
        schemaVersion: 3.19,
        authData: {
          domain: mockApl.workingSaleorDomain,
          token: mockApl.mockToken,
          jwks: mockApl.mockJwks,
          saleorApiUrl: mockApl.workingSaleorApiUrl,
	/* eslint-disable max-classes-per-file */
	import { APL, AuthData } from "@/APL";
	import { SALEOR_API_URL_HEADER, SALEOR_DOMAIN_HEADER } from "@/const";
Check failure on line 3 in src/handlers/actions/register-action-handler.ts GitHub Actions / lint `Module '"@/const"' has no exported member 'SALEOR_DOMAIN_HEADER'.` Check failure on line 3 in src/handlers/actions/register-action-handler.ts GitHub Actions / build `Module '"@/const"' has no exported member 'SALEOR_DOMAIN_HEADER'.`
	import { createDebug } from "@/debug";
	import { fetchRemoteJwks } from "@/fetch-remote-jwks";
	import { getAppId } from "@/get-app-id";
	private runPreChecks(): ActionHandlerResult \| null {
	const checksToRun = [
	this.adapterMiddleware.withMethod(["POST"]),
	this.adapterMiddleware.withSaleorDomainPresent(),
Check failure on line 124 in src/handlers/actions/register-action-handler.ts GitHub Actions / lint `Property 'withSaleorDomainPresent' does not exist on type 'PlatformAdapterMiddleware<I>'. Did you mean 'withSaleorApiUrlPresent'?` Check failure on line 124 in src/handlers/actions/register-action-handler.ts GitHub Actions / build `Property 'withSaleorDomainPresent' does not exist on type 'PlatformAdapterMiddleware<I>'. Did you mean 'withSaleorApiUrlPresent'?` Check failure on line 124 in src/handlers/actions/register-action-handler.ts GitHub Actions / test src/handlers/platforms/next/create-app-register-handler.test.ts > create-app-register-handler > Sets auth data for correct request `TypeError: this.adapterMiddleware.withSaleorDomainPresent is not a function ❯ RegisterActionHandler.runPreChecks src/handlers/actions/register-action-handler.ts:124:30 ❯ RegisterActionHandler.handleAction src/handlers/actions/register-action-handler.ts:139:33 ❯ src/handlers/platforms/next/create-app-register-handler.ts:38:42 ❯ src/handlers/platforms/next/create-app-register-handler.test.ts:48:11` Check failure on line 124 in src/handlers/actions/register-action-handler.ts GitHub Actions / test src/handlers/platforms/next/create-app-register-handler.test.ts > create-app-register-handler > Returns 403 if configured to work only for specific saleor URL and try to install on prohibited one `TypeError: this.adapterMiddleware.withSaleorDomainPresent is not a function ❯ RegisterActionHandler.runPreChecks src/handlers/actions/register-action-handler.ts:124:30 ❯ RegisterActionHandler.handleAction src/handlers/actions/register-action-handler.ts:139:33 ❯ src/handlers/platforms/next/create-app-register-handler.ts:38:42 ❯ src/handlers/platforms/next/create-app-register-handler.test.ts:85:11` Check failure on line 124 in src/handlers/actions/register-action-handler.ts GitHub Actions / test src/handlers/platforms/next/create-app-register-handler.test.ts > create-app-register-handler > Callback hooks > Runs callback hooks - successful saving to APL scenario `TypeError: this.adapterMiddleware.withSaleorDomainPresent is not a function ❯ RegisterActionHandler.runPreChecks src/handlers/actions/register-action-handler.ts:124:30 ❯ RegisterActionHandler.handleAction src/handlers/actions/register-action-handler.ts:139:33 ❯ src/handlers/platforms/next/create-app-register-handler.ts:38:42 ❯ src/handlers/platforms/next/create-app-register-handler.test.ts:131:13` Check failure on line 124 in src/handlers/actions/register-action-handler.ts GitHub Actions / test src/handlers/platforms/next/create-app-register-handler.test.ts > create-app-register-handler > Callback hooks > Runs callback hooks - failed saving to APL scenario `TypeError: this.adapterMiddleware.withSaleorDomainPresent is not a function ❯ RegisterActionHandler.runPreChecks src/handlers/actions/register-action-handler.ts:124:30 ❯ RegisterActionHandler.handleAction src/handlers/actions/register-action-handler.ts:139:33 ❯ src/handlers/platforms/next/create-app-register-handler.ts:38:42 ❯ src/handlers/platforms/next/create-app-register-handler.test.ts:195:13` Check failure on line 124 in src/handlers/actions/register-action-handler.ts GitHub Actions / test src/handlers/platforms/next/create-app-register-handler.test.ts > create-app-register-handler > Callback hooks > Allows to send custom error response via callback hook `TypeError: this.adapterMiddleware.withSaleorDomainPresent is not a function ❯ RegisterActionHandler.runPreChecks src/handlers/actions/register-action-handler.ts:124:30 ❯ RegisterActionHandler.handleAction src/handlers/actions/register-action-handler.ts:139:33 ❯ src/handlers/platforms/next/create-app-register-handler.ts:38:42 ❯ src/handlers/platforms/next/create-app-register-handler.test.ts:246:13`
	];

	for (const check of checksToRun) {

	const expectedAuthData: AuthData = {
	token: "mock-auth-token",
	domain: "https://mock-saleor-domain.saleor.cloud/",
Check failure on line 125 in src/handlers/platforms/next/create-app-register-handler.test.ts GitHub Actions / lint `Type '{ token: string; domain: string; saleorApiUrl: string; jwks: string; appId: string; }' is not assignable to type 'AuthData'.`
	saleorApiUrl: "https://mock-saleor-domain.saleor.cloud/graphql/",
	jwks: mockJwksValue,
	appId: mockAppId,

	const expectedAuthData: AuthData = {
	token: "mock-auth-token",
	domain: "https://mock-saleor-domain.saleor.cloud/",
Check failure on line 189 in src/handlers/platforms/next/create-app-register-handler.test.ts GitHub Actions / lint `Type '{ token: string; domain: string; saleorApiUrl: string; jwks: string; appId: string; }' is not assignable to type 'AuthData'.`
	saleorApiUrl: "https://mock-saleor-domain.saleor.cloud/graphql/",
	jwks: mockJwksValue,
	appId: mockAppId,
	payload: { data: "test_payload" },
	schemaVersion: 3.19,
	authData: {
	domain: "example.com",
Check failure on line 69 in src/handlers/platforms/next/saleor-webhooks/saleor-async-webhook.test.ts GitHub Actions / lint `Type '{ domain: string; token: string; jwks: string; saleorApiUrl: string; appId: string; }' is not assignable to type 'AuthData'.`
	token: "token",
	jwks: "",
	saleorApiUrl: "https://example.com/graphql/",