Drop support of "domain" header #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f428fce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
- Coverage 73.37% 73.04% -0.33%
==========================================
Files 79 78 -1
Lines 3061 3024 -37
Branches 457 454 -3
==========================================
- Hits 2246 2209 -37
Misses 810 810
Partials 5 5 ☔ View full report in Codecov by Sentry. |
witoszekdev
approved these changes
Jan 27, 2025
witoszekdev
pushed a commit
that referenced
this pull request
Jan 28, 2025
witoszekdev
added a commit
that referenced
this pull request
Jan 28, 2025
* Fix package.json license, add keywords and author * Add creative commons license as additional license * Add changeset * Add changeset * Fix OR -> AND license * Update prepare-release.yml * Update CodeCov to be informational * Drop support of "domain" header (#391) * update release flow docs (#390) * Removed CC license, update date in license file * Update changeset --------- Co-authored-by: Lukasz Ostrowski <[email protected]> Co-authored-by: Krzysztof Żuraw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first breaking change that will come to v1.0.0 of app-sdk
The
domainheader is no longer needed andsaleor-api-urlheader should be used.In v1 domain will not be available in app-sdk helpers