Catch up to TMX Format as of Tiled 0.12 #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and report map attributes in the test program.
Now that tmxparser is feature complete, I also suggest to release version 1.12 (1 being the last release of tmxparser, and 0.12 being the current Tiled release) after changing
src/Tmx.h
accordingly:I should also mention that tmxparser goes down in flames when an
<image>
element does not include thewidth
andheight
attributes, which are optional; line 167 ofTmxTileset.cpp
incorrectly assumes that those were parsed even when they were not, causing a crash in line 187 when trying to index into a zero-length vector. Instead of hacking something, I think it's about time to put error checking and assertions all over the place.