Sorted lists #110
Open
Sorted lists #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if I get your solution. It looks like you're limiting the list of items to 1000, so user can have either first 1000 songs/artists/albums from Spotify sorted by name or see everything. That's not really that good, if I have for example 2000 songs, I'd only get a half of that and it might be the ones I don't want. I think we should rather do some kind of caching, for example fetching all the data, storing it in a DB and somehow find a good way to figure out when should we refetch it. The good thing about that approach is that once everything is fetched, it should be running pretty smooth, even offline. Or we could just drop sorting until Spotify fixes their API: spotify/web-api#1195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.