-
-
Notifications
You must be signed in to change notification settings - Fork 648
Speed up coordinate_vector function #40591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
user202729
wants to merge
28
commits into
sagemath:develop
Choose a base branch
from
user202729:module-speed-up-coordinate
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Speed up coordinate_vector function #40591
user202729
wants to merge
28
commits into
sagemath:develop
from
user202729:module-speed-up-coordinate
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for this PR (built with commit a3ab0d3; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build up on #40497,
coordinate_vector
can use the same optimization.the
v = v.list()
is an unfortunate artifact of another suboptimality, namely we have the followingthis map is called even to convert a from a submodule of ℤ^2 to ℤ^2.
the problem is
ModuleMorphism
needs to (1) callcoordinate_vector
, then (2) multiply it by the basis matrix. and (1) leads to an infinite loop.Requires #40371
📝 Checklist
⌛ Dependencies
#40371