-
-
Notifications
You must be signed in to change notification settings - Fork 630
Remove Maxima pexpect interface #40265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 47e874e; changes) is ready! 🎉 |
Tests are green, so this is now ready for review. |
is this a total removal, or only making it optional? IIRC maxima pexpect is still used in few places in sagelib, because the glue code needed for library maxima is missing. @nbruin ought to know the details. There is somewhere an issue tracking the work to be done - I recall looking into it, and being unable to set an actionable plan towards completion of this task, as the API is very opaque and undocumented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I don't think I'm familiar enough with Maxima or how Sage interfaces to external libraries to review this. This doesn't appear to significantly touch any parts of Sage that I've worked on/with either. Was there any particular part you wanted me to look at?
It's a complete removal of the pexpect interface for maxima. There were a few places that still used it, but they where quite easy to migrate.
I didn't knew which to tag for review and github was suggesting you. Sorry for the noise. |
Fixes #17753 and fixes #30071
📝 Checklist
⌛ Dependencies