Skip to content

Remove Maxima pexpect interface #40265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Jun 17, 2025

Fixes #17753 and fixes #30071

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jun 18, 2025

Documentation preview for this PR (built with commit 47e874e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez
Copy link
Contributor Author

Tests are green, so this is now ready for review.

@tobiasdiez tobiasdiez marked this pull request as ready for review June 19, 2025 07:30
@dimpase
Copy link
Member

dimpase commented Jun 19, 2025

is this a total removal, or only making it optional?

IIRC maxima pexpect is still used in few places in sagelib, because the glue code needed for library maxima is missing.

@nbruin ought to know the details. There is somewhere an issue tracking the work to be done - I recall looking into it, and being unable to set an actionable plan towards completion of this task, as the API is very opaque and undocumented

Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I don't think I'm familiar enough with Maxima or how Sage interfaces to external libraries to review this. This doesn't appear to significantly touch any parts of Sage that I've worked on/with either. Was there any particular part you wanted me to look at?

@tobiasdiez
Copy link
Contributor Author

is this a total removal, or only making it optional?

IIRC maxima pexpect is still used in few places in sagelib, because the glue code needed for library maxima is missing.

It's a complete removal of the pexpect interface for maxima. There were a few places that still used it, but they where quite easy to migrate.

Sorry, but I don't think I'm familiar enough with Maxima or how Sage interfaces to external libraries to review this. This doesn't appear to significantly touch any parts of Sage that I've worked on/with either. Was there any particular part you wanted me to look at?

I didn't knew which to tag for review and github was suggesting you. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speed up Maxima computations by using more of maxima_calculus.eval() move pexpect-maxima code to maxima_lib
3 participants