ensure autoconf 2.69 compatiblity in configure.ac #40261
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by @jeriedel24 [here](sagemath@7f6dd75#commitcomment-160100961) old autoconf does not correctly deal with `test` clauses split across the lines. So we fix it here
|
Documentation preview for this PR (built with commit 1812703; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 17, 2025
As reported by @jeriedel24 [here](https://github.com/sagemath/sage/commi t/7f6dd7547ecf8c4d23099842f4ad4ace5f2f3072#commitcomment-160100961), old autoconf does not correctly deal with `test` clauses split across the lines. So we fix this regression, introduced in sagemath#40011, here. We still cannot drop autoconf 2.69, as various distros, e.g. Debian, are very slow in adapting 2.71+ <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40261 Reported by: Dima Pasechnik Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 18, 2025
sagemathgh-40261: ensure autoconf 2.69 compatiblity in configure.ac As reported by @jeriedel24 [here](https://github.com/sagemath/sage/commi t/7f6dd7547ecf8c4d23099842f4ad4ace5f2f3072#commitcomment-160100961), old autoconf does not correctly deal with `test` clauses split across the lines. So we fix this regression, introduced in sagemath#40011, here. We still cannot drop autoconf 2.69, as various distros, e.g. Debian, are very slow in adapting 2.71+ <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40261 Reported by: Dima Pasechnik Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 21, 2025
sagemathgh-40261: ensure autoconf 2.69 compatiblity in configure.ac As reported by @jeriedel24 [here](https://github.com/sagemath/sage/commi t/7f6dd7547ecf8c4d23099842f4ad4ace5f2f3072#commitcomment-160100961), old autoconf does not correctly deal with `test` clauses split across the lines. So we fix this regression, introduced in sagemath#40011, here. We still cannot drop autoconf 2.69, as various distros, e.g. Debian, are very slow in adapting 2.71+ <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40261 Reported by: Dima Pasechnik Reviewer(s): Tobias Diez
|
@vbraun - I added CI fix label to indicate that this breaks CI runs (these which run ./bootstrap on old autoconf, <2.70) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @jeriedel24 here, old autoconf does not correctly deal with
testclauses split across the lines. So we fix this regression, introduced in #40011, here.We still cannot drop autoconf 2.69, as various distros, e.g. Debian, are very slow in adapting 2.71+
📝 Checklist
⌛ Dependencies