moving linear_intervals_count to hasse as iterator #40245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 224b915; changes) is ready! 🎉 |
|
@tscrim, if you have some time to look, should be easy |
tscrim
approved these changes
Jun 16, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 17, 2025
sagemathgh-40245: moving linear_intervals_count to hasse as iterator to make them still faster ; also changed the moved method into an iterator as this could be convenient follow-up of previous effort in sagemath#40171 Timings : poset of size 4800 : 18s before ; 13 after poset of size 5300 : 24.4 s before and17.4 s after ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40245 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 18, 2025
sagemathgh-40245: moving linear_intervals_count to hasse as iterator to make them still faster ; also changed the moved method into an iterator as this could be convenient follow-up of previous effort in sagemath#40171 Timings : poset of size 4800 : 18s before ; 13 after poset of size 5300 : 24.4 s before and17.4 s after ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40245 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 21, 2025
sagemathgh-40245: moving linear_intervals_count to hasse as iterator to make them still faster ; also changed the moved method into an iterator as this could be convenient follow-up of previous effort in sagemath#40171 Timings : poset of size 4800 : 18s before ; 13 after poset of size 5300 : 24.4 s before and17.4 s after ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40245 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make them still faster ; also changed the moved method into an iterator as this could be convenient
follow-up of previous effort in #40171
Timings :
poset of size 4800 : 18s before ; 13 after
poset of size 5300 : 24.4 s before and17.4 s after
📝 Checklist