Skip to content

typing annotations for is_something in knots,quadratic_forms,quivers #39995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

typing annotations for is_something in knots,quadratic_forms,quivers #39995

merged 1 commit into from
Apr 29, 2025

Conversation

fchapoton
Copy link
Contributor

add the annotation -> bool where appropriate in the folders knots, quadratic_forms and quivers

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit feb01b6; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tscrim
tscrim approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 14e9964 into sagemath:develop Apr 29, 2025
21 of 22 checks passed
@fchapoton fchapoton deleted the typing_is_knots_qf_quivers branch April 30, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @tscrim @vbraun