Raise exception when transformation not supported for echelon_form() #39981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37480
This is a preliminary fix for the issue mentioned, where it raises exception whenever
echelon_form()
does not support argument "transformation=True".The list of all matrix class that has its own
echelon_form()
:matrix2
matrix_cyclo_dense
matrix_integer_dense
matrix_mpolynomial_dense
matrix_rational_dense
matrix_rational_sparse
The list of matrix class that does not support transformation and thus modified to raise exception:
matrix_cyclo_dense
matrix_mpolynomial_dense.pyx
matrix_rational_dense.pyx
matrix_rational_sparse.pyx
We should for the moment use this fix for the issue so that we don't have the "ignore user input" phenomenon, but keep the issue for future.
📝 Checklist
⌛ Dependencies
cc @vneiger @maxale