-
-
Notifications
You must be signed in to change notification settings - Fork 629
Upgrade singular to 4.4.1 #39967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade singular to 4.4.1 #39967
Conversation
On my machine the hashes are
how can the hash on your machine be different? |
Maybe I messed something up yesterday when I determined the checksums -- or the tarball from their own mirror at https://www.singular.uni-kl.de/ftp/pub/Math/Singular/SOURCES/4-4-1/ is different. Odd! |
Superseded by #40033. |
I'm sorry I missed this while working on #40033 |
No worries! I didn't manage to submit PRs for the other patches I found anyways; I still have it on my stack though. In fact, I was wondering: there is probably a reason why sage ships with its own patched and updated version of gfan instead of trying to incorporate the version bundled with Singular? |
To probably answer my own question: gfan vs gfanlib? Perhaps I just got confused because I saw the same compilation errors both in gfanlib built by and included in our singular package, and our gfan package. |
as a rule, we try not to use vendored by upstreams stuff. I'll open a PR to update gfan to 0.7, but @orlitzky says it doesn't work on musl Linux, e.g. on void Linux. |
v0.7 uses nonstandard 128-bit types ( Re: gfanlib, the homepage says,
I don't know if that's a passive aggressive comment aimed at the Singular/CoCoA devs, or simply a statement of fact that gfanlib has not meaningfully changed. Now that gcc-15 is our, both gfan and singular (which bundles it) are going to fail to build as well: Singular/Singular#1242 |
Has anyone made a meaningful build system for gfan? Its updated Makefile has to be patched more or less from scratch. |
Closes #39966. In particular, this allows singular to build using clang17 on my mac. I've tested this locally, build seemed fine.
📝 Checklist