Skip to content

Upgrade singular to 4.4.1 #39967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

behackl
Copy link
Member

@behackl behackl commented Apr 18, 2025

Closes #39966. In particular, this allows singular to build using clang17 on my mac. I've tested this locally, build seemed fine.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@user202729
Copy link
Contributor

user202729 commented Apr 19, 2025

#30 2310.1 [singular-4.4.1] installing. Log file: /sage/logs/pkgs/singular-4.4.1.log
#30 2310.1   [singular-4.4.1] error installing, exit status 1. Log file:
#30 2310.1   [singular-4.4.1]   Attempting to download package singular-4.4.1.tar.gz from mirrors
#30 2310.1   [singular-4.4.1]   https://github.com/sagemath/sage/releases/download/10.7/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//github.com/sagemath/sage/releases/download/10.7/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   https://github.com/sagemath/sage/releases/download/10.6/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//github.com/sagemath/sage/releases/download/10.6/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   http://files.sagemath.org/spkg/upstream/singular/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//files.sagemath.org/spkg/upstream/singular/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   https://ftp.rediris.es/mirror/sagemath/spkg/upstream/singular/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//ftp.rediris.es/mirror/sagemath/spkg/upstream/singular/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   https://ftp.riken.jp/sagemath/spkg/upstream/singular/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//ftp.riken.jp/sagemath/spkg/upstream/singular/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   https://ftp.yz.yamagata-u.ac.jp/pub/math/sage/spkg/upstream/singular/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//ftp.yz.yamagata-u.ac.jp/pub/math/sage/spkg/upstream/singular/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   https://fosszone.csd.auth.gr/sagemath/spkg/upstream/singular/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//fosszone.csd.auth.gr/sagemath/spkg/upstream/singular/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   https://ftp.sun.ac.za/ftp/pub/mirrors/www.sagemath.org/spkg/upstream/singular/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//ftp.sun.ac.za/ftp/pub/mirrors/www.sagemath.org/spkg/upstream/singular/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   http://linorg.usp.br/sage/spkg/upstream/singular/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
#30 2310.1   [singular-4.4.1]   ERROR [transfer|run:135]: [Errno socket error] [Errno 404] Not Found: '//linorg.usp.br/sage/spkg/upstream/singular/singular-4.4.1.tar.gz'
#30 2310.1   [singular-4.4.1]   Attempting to download from ftp://jim.mathematik.uni-kl.de/pub/Math/Singular/SOURCES/4-4-1/singular-4.4.1.tar.gz
#30 2310.1   [singular-4.4.1]   [......................................................................]
#30 2310.1   [singular-4.4.1]   Traceback (most recent call last):
#30 2310.1   [singular-4.4.1]     File "/sage/build/bin/sage-package", line 40, in <module>
#30 2310.1   [singular-4.4.1]       run()
#30 2310.1   [singular-4.4.1]     File "/sage/build/bin/../sage_bootstrap/cmdline.py", line 538, in run
#30 2310.1   [singular-4.4.1]       app.download_cls(*args.package_class,
#30 2310.1   [singular-4.4.1]     File "/sage/build/bin/../sage_bootstrap/app.py", line 337, in download_cls
#30 2310.1   [singular-4.4.1]       pc.apply(download_with_args)
#30 2310.1   [singular-4.4.1]     File "/sage/build/bin/../sage_bootstrap/expand_class.py", line 126, in apply
#30 2310.1   [singular-4.4.1]       function(package_name, *args, **kwds)
#30 2310.1   [singular-4.4.1]     File "/sage/build/bin/../sage_bootstrap/app.py", line 329, in download_with_args
#30 2310.1   [singular-4.4.1]       self.download(package, allow_upstream=allow_upstream)
#30 2310.1   [singular-4.4.1]     File "/sage/build/bin/../sage_bootstrap/app.py", line 315, in download
#30 2310.1   [singular-4.4.1]       package.tarball.download(allow_upstream=allow_upstream)
#30 2310.1   [singular-4.4.1]     File "/sage/build/bin/../sage_bootstrap/tarball.py", line 191, in download
#30 2310.1   [singular-4.4.1]       raise ChecksumError('checksum does not match')
#30 2310.1   [singular-4.4.1]   sage_bootstrap.tarball.ChecksumError: checksum does not match
#30 2310.1   [singular-4.4.1]   ************************************************************************
#30 2310.1   [singular-4.4.1]   Error downloading tarball of singular
#30 2310.1   [singular-4.4.1]   ************************************************************************
#30 2310.1   [singular-4.4.1]   Please email sage-devel (http://groups.google.com/group/sage-devel)
#30 2310.1   [singular-4.4.1]   explaining the problem and including the log files
#30 2310.1   [singular-4.4.1]     /sage/logs/pkgs/singular-4.4.1.log
#30 2310.1   [singular-4.4.1]   and
#30 2310.1   [singular-4.4.1]     /sage/config.log
#30 2310.1   [singular-4.4.1]   Describe your computer, operating system, etc.
#30 2310.1   [singular-4.4.1]   ************************************************************************
#30 2310.1 make[4]: *** [Makefile:3412: singular-SAGE_LOCAL-no-deps] Error 1
#30 2310.1 make[3]: *** [Makefile:3412: /sage/local/var/lib/sage/installed/singular-4.4.1] Error 2

On my machine the hashes are

[sage]$ sha1sum singular-4.4.1.tar.gz 
0578f25204102ba70cb56c7543b37e98a389f22a  singular-4.4.1.tar.gz
[sage]$ sha256sum singular-4.4.1.tar.gz 
6a4fbaaed05b89c35bff3b1c5e124344a088097f81affe129c9ae619b282b49b  singular-4.4.1.tar.gz

how can the hash on your machine be different?

@behackl
Copy link
Member Author

behackl commented Apr 19, 2025

Maybe I messed something up yesterday when I determined the checksums -- or the tarball from their own mirror at https://www.singular.uni-kl.de/ftp/pub/Math/Singular/SOURCES/4-4-1/ is different. Odd!

@behackl behackl mentioned this pull request Apr 30, 2025
5 tasks
@behackl
Copy link
Member Author

behackl commented Apr 30, 2025

Superseded by #40033.

@behackl behackl closed this Apr 30, 2025
@dimpase
Copy link
Member

dimpase commented Apr 30, 2025

I'm sorry I missed this while working on #40033

@behackl
Copy link
Member Author

behackl commented Apr 30, 2025

No worries! I didn't manage to submit PRs for the other patches I found anyways; I still have it on my stack though.

In fact, I was wondering: there is probably a reason why sage ships with its own patched and updated version of gfan instead of trying to incorporate the version bundled with Singular?

@behackl
Copy link
Member Author

behackl commented Apr 30, 2025

To probably answer my own question: gfan vs gfanlib? Perhaps I just got confused because I saw the same compilation errors both in gfanlib built by and included in our singular package, and our gfan package.

@dimpase
Copy link
Member

dimpase commented Apr 30, 2025

To probably answer my own question: gfan vs gfanlib? Perhaps I just got confused because I saw the same compilation errors both in gfanlib built by and included in our singular package, and our gfan package.

as a rule, we try not to use vendored by upstreams stuff. I'll open a PR to update gfan to 0.7, but @orlitzky says it doesn't work on musl Linux, e.g. on void Linux.

@orlitzky
Copy link
Contributor

orlitzky commented May 1, 2025

v0.7 uses nonstandard 128-bit types (__int128_t , __uint128_t) and arithmetic in a lot of places and is non-portable as a result.

Re: gfanlib, the homepage says,

Comment to the Singular/CoCoA developers: It is not possible to extract a useful updated version of gfanlib from the sources.

I don't know if that's a passive aggressive comment aimed at the Singular/CoCoA devs, or simply a statement of fact that gfanlib has not meaningfully changed.

Now that gcc-15 is our, both gfan and singular (which bundles it) are going to fail to build as well: Singular/Singular#1242

@dimpase
Copy link
Member

dimpase commented May 1, 2025

Has anyone made a meaningful build system for gfan? Its updated Makefile has to be patched more or less from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade singular to >= 4.4.1
4 participants