Corrected word_problem parsing and added algorithm option #39820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @dimpase @fchapoton Can you please review this, and give feedback about the fix. |
|
there is a CI error: |
EigenVector22
force-pushed
the
fix-word-problem-36419
branch
from
45a52de to
63cb1ec
Compare
|
made the necessary changes, |
|
It looks like some CI checks are failing in unrelated files (linear_code.py, polynomial_element.pyx) with timeouts/cysignal errors, and there's also a Docker image pull error. These seem unrelated to the changes in permgroup_element.pyx, as local tests for that file pass? |
fchapoton
reviewed
Mar 30, 2025
EigenVector22
force-pushed
the
fix-word-problem-36419
branch
from
63cb1ec to
dbd9c9f
Compare
|
made the change |
|
Why are some tests failing? Have I done any mistake in the implementation? |
fchapoton
reviewed
Mar 30, 2025
This replaces the fragile string parsing in PermutationGroupElement.word_problem with a stable method using GAP's syllable functions (NumberSyllables, GeneratorSyllable, ExponentSyllable). This resolves parsing errors involving parentheses and generator name conflicts (e.g., x10 vs x1). Introduces an 'algorithm' parameter: - 'syllable' (Now default): Returns 1-based generator indices when as_list=True. - 'legacy': Old implementation, preserved for testing but deprecated due to known bugs. Returns generator strings when as_list=True. Updated docstrings and examples accordingly. Fixes sagemath#36419 Related: sagemath#28556
EigenVector22
force-pushed
the
fix-word-problem-36419
branch
from
dbd9c9f to
9eb3f7b
Compare
|
@fchapoton @dimpase, any further suggestions for revisions? |
docs don't build - please fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the fragile string parsing in PermutationGroupElement.word_problem with a stable method using GAP's syllable functions (NumberSyllables, GeneratorSyllable, ExponentSyllable). This resolves parsing errors involving parentheses and generator name conflicts (e.g., x10 vs x1).
Introduces an 'algorithm' parameter:
Updated docstrings and examples accordingly.
Fixes #36419
Also #37042 is taken care of
Related: #28556
📝 Checklist
⌛ Dependencies