fix: added check for FriCAS version

[devansh-srv]

This pull request includes several updates to the FriCAS class in the src/sage/features/fricas.py file. The changes introduce a minimum version requirement, add a method to retrieve the installed FriCAS version, and enhance the is_functional method to check the version.This is an attempt to fix the issue 39784

Enhancements to version handling and functionality checks:

• src/sage/features/fricas.py: Added a MINIMUM_VERSION attribute to specify the minimum required version of FriCAS.
• src/sage/features/fricas.py: Introduced a get_version method to retrieve the installed FriCAS version.
• src/sage/features/fricas.py: Updated the is_functional method to call get_version and check if the installed version meets the minimum requirement. If the version is not retrievable or is too old, appropriate error messages are returned.

📝 Checklist

• The title is concise and informative.
• The description explains in detail what this PR is about.
• I have linked a relevant issue or discussion.
• I have created tests covering the changes.
• I have updated the documentation and checked the documentation preview.

⌛ Dependencies

[devansh-srv]

Hey @dimpase
I have checked that the url https://fricas.github.io/ refers to version 1.3.11
but this ticket concludes that FriCAS support was updated to 1.3.8
so I think 1.3.8 version check would be appropriate but I need to be sure
I am not on a Ubuntu machine (rather an arch machine)

[dimpase]

indeed, anything earlier than 1.3.8 wasn't supported. Perhaps some tests, updated for newer FriCAS, might now fail, but that's OK

[tscrim]

cc-ing @mantepse just in case

[github-actions]

Documentation preview for this PR (built with commit 9897efb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

[dimpase]

can we use a non-deprecated API here?

>>> from pkg_resources import parse_version
<stdin>:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html

[dimpase]

e.g. you can use https://packaging.pypa.io/en/stable/version.html

[devansh-srv]

e.g. you can use https://packaging.pypa.io/en/stable/version.html

We can but is it causing any issue in the building process?

pkg_resources

@dimpase the package pkg_resources definitely needs to go as it is deprecated as shown by pytorch ticket 139170
I have made the necessary changes using the packaging.version package
I have also written and optional EXAMPLE doctest for the get_version() method
you may have a look on these latest changes

[devansh-srv]

Please review the changes @dimpase

[dimpase]

e.g. you can use https://packaging.pypa.io/en/stable/version.html

We can but is it causing any issue in the building process?

Deprecated features should not be used in newly written code, this is the only reason for my request

pkg_resources

@dimpase the package pkg_resources definitely needs to go as it is deprecated as shown by pytorch ticket 139170

There are more uses of it across Sage code,
which need fixing before we can remove it

I have made the necessary changes using the packaging.version package
I have also written and optional EXAMPLE doctest for the get_version() method
you may have a look on these latest changes

[devansh-srv]

e.g. you can use https://packaging.pypa.io/en/stable/version.html

We can but is it causing any issue in the building process?

Deprecated features should not be used in newly written code, this is the only reason for my request

pkg_resources

@dimpase the package pkg_resources definitely needs to go as it is deprecated as shown by pytorch ticket 139170

There are more uses of it across Sage code, which need fixing before we can remove it

I have made the necessary changes using the packaging.version package
I have also written and optional EXAMPLE doctest for the get_version() method
you may have a look on these latest changes

In the latest changes I have remove pkg_resources and use the package that you have suggested
I think this should be fine

[devansh-srv]

Hey @dimpase any specific instructions for me over this PR ?
Just needed to know if I need to change something

[dimpase]

your test for fricas version is too explicit. As we allow external fricas, it could be another version.

All you know is that's it's 1.3.something.

please replace 8 with dots, as done in such cases

[dimpase]

Please add the following comment

--- a/build/pkgs/fricas/spkg-configure.m4
+++ b/build/pkgs/fricas/spkg-configure.m4
@@ -1,4 +1,7 @@
 SAGE_SPKG_CONFIGURE(
+dnl
+dnl make sure that the minimal version is also set in src/sage/feature/fricas.py
+dnl
     [fricas], [
         AC_CACHE_CHECK([for FriCAS >= 1.3.8], [ac_cv_path_FRICAS], [
         AC_PATH_PROGS_FEATURE_CHECK([FRICAS], [fricas], [

Otherwise it's good to go.

@roed314 - please turn this to Positive review

[devansh-srv]

Please add the following comment

--- a/build/pkgs/fricas/spkg-configure.m4
+++ b/build/pkgs/fricas/spkg-configure.m4
@@ -1,4 +1,7 @@
 SAGE_SPKG_CONFIGURE(
+dnl
+dnl make sure that the minimal version is also set in src/sage/feature/fricas.py
+dnl
     [fricas], [
         AC_CACHE_CHECK([for FriCAS >= 1.3.8], [ac_cv_path_FRICAS], [
         AC_PATH_PROGS_FEATURE_CHECK([FRICAS], [fricas], [

Otherwise it's good to go.

@roed314 - please turn this to Positive review

shall I do these changes now?

[dimpase]

yes, of course.
At the moment we don't have a clear way to make sure there is only one source for the minimal version of an optional package like fricas,
so the purpose of this comment is to make sure that in the future these versions don't get out of sync.

[devansh-srv]

@dimpase I have made the suggested changes in the file /build/pkgs/fricas/spkg-configure.m4
Have a look