Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrote methods concerning subdivision of edges in a matching covered graph #39650

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

janmenjayap
Copy link
Contributor

@janmenjayap janmenjayap commented Mar 8, 2025

The objective of this issue is to overwrite the methods pertaining to subdivision of edges in a matching covered graph.

More specifically, this PR aims to overwrite the following methods:

  • subdivide_edge() | Subdivide an edge k times.
  • subdivide_edges() | Subdivide k times edges from an iterable container.

This PR shall address the methods related to subdivision of edge(s) in matching covered graphs.

Fixes #38216.
Note that this issue fixes a small part of the mentioned issue.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Nothing as of now.

cc: @dcoudert.

Copy link

github-actions bot commented Mar 8, 2025

Documentation preview for this PR (built with commit e9c81d3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@janmenjayap janmenjayap changed the title Implemented methods concerning subdivision of edges in a matching covered graph Overwrote methods concerning subdivision of edges in a matching covered graph Mar 9, 2025
@janmenjayap janmenjayap requested a review from dcoudert March 15, 2025 15:27
@janmenjayap
Copy link
Contributor Author

Hi,
I have added the case if the arguments are provided like to subdivide the four edges, each of which is, (0, 1, None), but the graph has at most 3 of it, it shall throw a ValueError.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@janmenjayap
Copy link
Contributor Author

Hi @dcoudert,
It seems like there are lines which have not been covered by doctests.

Could you please set it back to needs work?
Thank you.

@dcoudert
Copy link
Contributor

It was already back to needs review when you rebased on rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Decompositions, Generation Methods and related concepts in the theory of Matching Covered Graphs
2 participants