Improve sage_getfile by looking at __init__ #39499
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it will fail with meson editable install on objects like
x
of typeExpression
, where the class does not have a docstring but__init__
method have.The strategy is similar to
sage_getsourcelines
where__init__
method is looked in.I choose to implement this instead of the more complex workaround (see the comment below).
This fixes the test that fails in meson editable mode:
This may still fail in another case where neither class nor
__init__
method has a docstring (in that case?
will fail to get the file in meson editable mode), but that's not in scope I guess. (I left a comment there to explain)See also #39369
📝 Checklist
⌛ Dependencies