Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some deprecations in groups #39466

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

remove some deprecations in groups #39466

wants to merge 5 commits into from

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Feb 6, 2025 •
edited
Loading

found using the scripts in #39262

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

dcoudert
dcoudert approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun
Copy link
Member

vbraun commented Feb 9, 2025

Docbuild fails as in the CI run

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

Documentation preview for this PR (built with commit bc23f92; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert
Copy link
Contributor

it seems you must also remove homset.py from some meson.build files https://github.com/sagemath/sage/actions/runs/13259123232/job/37011513831?pr=39466#step:8:90

@fchapoton
Copy link
Contributor Author

oui, effectivement. Je deteste ce truc meson.. merci !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: group theory s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @vbraun @dcoudert