Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword prec for exponential and logarithm of Drinfeld modules #39214

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Dec 28, 2024

Currently, the methods exponential and logarithm for Drinfeld modules return a LazyPowerSeriesRing for which not all methods are available.
We add a keyword prec. When it is Infinity (which is the default), the behavior is unchanged. However, when we pass in a finite number, a classical power series (up to the given precision) is returned.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Dec 28, 2024

Documentation preview for this PR (built with commit 1fa959b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mantepse
Copy link
Collaborator

Off topic: Which methods are missing in LazyPowerSeries?

@xcaruso
Copy link
Contributor Author

xcaruso commented Dec 28, 2024

e.g. sqrt (it is implemented only for series congruent to 1 modulo x), nth_root, continued_fraction...
Also printing more terms is a little bit tricky; we need to set the parameter parent.options.display_length (which moreover is global, we cannot easily change this for just one shot).

@mantepse
Copy link
Collaborator

e.g. sqrt (it is implemented only for series congruent to 1 modulo x), nth_root,

Oh, I missed the possibility of taking out x^n!

continued_fraction...

I actually have code for that, but was too lazy to get it in.

Also printing more terms is a little bit tricky; we need to set the parameter parent.options.display_length (which moreover is global, we cannot easily change this for just one shot).

I agree. Maybe we can discuss this at sd128?

@xcaruso xcaruso requested a review from kryzar December 29, 2024 12:42
xcaruso and others added 3 commits January 3, 2025 09:47
Co-authored-by: Martin Rubey <[email protected]>
@xcaruso
Copy link
Contributor Author

xcaruso commented Jan 3, 2025

Also printing more terms is a little bit tricky; we need to set the parameter parent.options.display_length (which moreover is global, we cannot easily change this for just one shot).

I agree. Maybe we can discuss this at sd128?

Sure!
I implemented a few years ago exact $p$-adics using relaxed artihemtics. The precision model there is able to handle both infinite and finite precision in the same parent. Maybe, it's also a good option to follow this.

@kryzar
Copy link
Contributor

kryzar commented Jan 21, 2025

Once again, it seems that the failed tests are independent to that PR:

@xcaruso, could you merge from develop and push here? I have hope this will fix the issue. (I don't believe I have authorizations on your fork (which I am not asking for), as I tried to do that but failed.)

Copy link
Contributor

@kryzar kryzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did my review. I only request that you add the latest changes from develop. My comments in the review are only suggestions, and you can freely choose to accept them or not. I'll approve the review either way. The only thing truly missing are the valid automatic tests (which unfortunately do not seem to be your fault's...).

Thank you very much for this lovely and useful PR 💙

@xcaruso xcaruso added the sd128 tickets of Sage Days 128 Le Teich label Feb 11, 2025
@kryzar kryzar self-requested a review February 12, 2025 21:55
Copy link
Contributor

@kryzar kryzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, these failing doctests seem unrelated to our work. Therefore, I approve the PR.

Many thanks to Xavier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: positive review sd128 tickets of Sage Days 128 Le Teich
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants