Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add free disk space option to Docker build default #37476

Merged
1 commit merged into from
Mar 10, 2024

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Feb 26, 2024

Extracts from #37351 the important and uncontroversal parts. Fixes the build errors of the default run: https://github.com/sagemath/sage/actions/runs/8037559468/job/21952518852
Closes #37330.

Author: @mkoeppe
Reviewer: @tobiasdiez

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor Author

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbraun this would be nice to have (but not utterly important) as it decreases the execution times of the Build & Test runs on ci.

Copy link

Documentation preview for this PR (built with commit c94fcd0; changes) is ready! 🎉

@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 5, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 8, 2024
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Extracts from sagemath#37351 the important
and uncontroversal parts. Fixes the build errors of the default run:
https://github.com/sagemath/sage/actions/runs/8037559468/job/21952518852
Closes sagemath#37330.

Author: @mkoeppe
Reviewer: @tobiasdiez

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#37476
Reported by: Tobias Diez
Reviewer(s): Tobias Diez
@vbraun vbraun closed this pull request by merging all changes into sagemath:develop in e417e22 Mar 10, 2024
@tobiasdiez tobiasdiez deleted the m-cherrypick branch November 5, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Linux "default" build broken
4 participants