Refactor Sourcify Client #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
requested review from
fmrsabino,
moisses89 and
iamacook
and removed request for
a team
moisses89
reviewed
Dec 11, 2023
|
|
||
| @cache | ||
| def get_chains(self) -> Dict[str, Any]: | ||
| return self._do_request("https://sourcify.dev/server/chains") |
There was a problem hiding this comment.
This url could be better in a constant.
- Rename `Sourcify` to `SourcifyClient` - Add method to check networks not supported - Raise a `SourcifyClientConfigurationProblem` if network is not supported
Uxio0
force-pushed
the
refactor-sourcify
branch
from
8b8cda9 to
0be2b31
Compare
moisses89
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourcifytoSourcifyClientSourcifyClientConfigurationProblemif network is not supported