Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blockscout url validation in github flow #1547

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Update blockscout url validation in github flow #1547

merged 2 commits into from
Feb 6, 2025

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez commented Feb 6, 2025 •
edited
Loading

moisses89
moisses89 reviewed Feb 6, 2025
View reviewed changes
.github/scripts/github_adding_addresses/validate_new_address_issue_input_data.py Outdated
@@ -363,8 +365,8 @@ def validate_issue_inputs() -> None:
print("Inputs to validate:")
print(f"Chain ID: {chain_id_input}")
print(f"RPC URL: {rpc_url}")
print(f"Blockscout Client URL: {blockscout_client_url}")
print(f"Etherscan Client URL: {etherscan_client_url}")
print(f"Blockscout Client V1 URL: {blockscout_client_url}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is V2 right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in the issue we ask for V1. For V2, you don't need to indicate a specific URL for each chain. Already indicated in the field description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, but it is blockscout not etherscan.

Copy link
Contributor Author

@falvaradorodriguez falvaradorodriguez Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here

@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review February 6, 2025 14:40
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner February 6, 2025 14:40
@falvaradorodriguez falvaradorodriguez merged commit 9a8059e into main Feb 6, 2025
3 of 7 checks passed
@falvaradorodriguez falvaradorodriguez deleted the update-new-addresses-github-flow branch February 6, 2025 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update new addresses github flow
3 participants
@falvaradorodriguez @Uxio0 @moisses89