Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated serializers #1546

Closed
wants to merge 1 commit into from
Closed

Remove deprecated serializers #1546

wants to merge 1 commit into from

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review February 5, 2025 14:27
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner February 5, 2025 14:27
Uxio0
Uxio0 requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serializers should be ready for people who want to use them. MultisigTransaction is lacking fields like base_gas, etc.

@falvaradorodriguez
Copy link
Contributor Author

Serializers should be ready for people who want to use them. MultisigTransaction is lacking fields like base_gas, etc.

Ok, makes sense. I close this PR then.

@falvaradorodriguez falvaradorodriguez deleted the standardise-api-fields branch February 6, 2025 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falvaradorodriguez @Uxio0