Skip to content

Conversation

@00salmon
Copy link
Contributor

@00salmon 00salmon commented Dec 5, 2025

Description of the change

shadow: true was added to name fields recently, but this broke shoelace's ability to pick it up as a form control

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copilot AI review requested due to automatic review settings December 5, 2025 22:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression where adding shadow: true to the name fields component broke Shoelace's ability to recognize it as a form control. The fix removes the shadow DOM configuration to restore form functionality.

Key changes:

  • Removed shadow: true from the sqm-name-fields component configuration
  • Bumped package version from 2.0.5 to 2.0.6
  • Updated CHANGELOG with release notes

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
packages/mint-components/src/components/sqm-name-fields/sqm-name-fields.tsx Removed shadow: true property from component decorator to fix form control detection
packages/mint-components/package.json Incremented version to 2.0.6 for this bug fix release
packages/mint-components/CHANGELOG.md Added release notes for version 2.0.6 documenting the shadow DOM removal
Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@noahwc noahwc merged commit 3f4cf5b into master Dec 5, 2025
11 of 14 checks passed
@noahwc noahwc deleted the fix-name-fields branch December 5, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants