Fix Cash Tooltip and Support Link #472
Conversation
…placed sl-tooltip in dashboard view to use a sl-dropdown
There was a problem hiding this comment.
Pull request overview
This PR fixes a tooltip display issue by replacing sl-tooltip with sl-dropdown to enable clickable content, specifically adding a clickable support link within the indirect tax information tooltip.
Key changes:
- Replaced
sl-tooltipwithsl-dropdowncomponent for the indirect tax information tooltip - Added custom styling to replicate tooltip appearance using dropdown
- Updated tooltip text to include a placeholder for a clickable support link
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sqm-tax-and-cash-dashboard.tsx | Updated indirectTaxTooltipSupport prop default value to include {supportLink} placeholder |
| sqm-tax-and-cash-dashboard-view.tsx | Replaced tooltip with dropdown component, added hover behavior handler, styled dropdown to match tooltip appearance, and implemented support link with intl formatting |
| readme.md | Updated documentation to reflect new default value with {supportLink} placeholder |
| package.json | Bumped version from 2.0.5 to 2.0.6-0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx
Show resolved
Hide resolved
...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx
Outdated
Show resolved
Hide resolved
...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx
Show resolved
Hide resolved
zachharrison
left a comment
zachharrison
left a comment
There was a problem hiding this comment.
Everything looks good, just need to adjust the version before merging
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return () => { | ||
| trigger.removeEventListener("mouseenter", show); | ||
| trigger.removeEventListener("mouseleave", scheduleHide); | ||
| panel.removeEventListener("mouseenter", show); | ||
| panel.removeEventListener("mouseleave", scheduleHide); | ||
| clearTimeout(hideTimeout); | ||
| }; |
There was a problem hiding this comment.
The dropdownHover function returns a cleanup function but nothing calls it, leading to event listener leaks. This cleanup function should be called when the component is unmounted or the ref changes. Consider using this return value in a useEffect or similar cleanup mechanism.
…placed sl-tooltip in dashboard view to use a sl-dropdown
Description of the change
Tooltip was not display correctly and sl-tooltip content is not clickable so I tried a workaround with sl-dropdown
Type of change
Links
Checklists
Development
Paperwork
Code review