-
Notifications
You must be signed in to change notification settings - Fork 1
Fixed unset tax form fields getting disabled #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where previously unset tax form fields were incorrectly being disabled. The fix refactors the disabled state logic by splitting a single isDisabledInput function into two separate functions: isDisabledPartnerInput (for partner data) and isDisabledUserInput (for user data). This ensures that fields are only disabled when they have actual values, not when they're simply in a user or partner state.
Key Changes:
- Refactored disabled input logic to properly handle partner vs. user input states
- Added comprehensive Storybook stories for testing various form states
- Updated package version to 2.0.5 with changelog entry
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/mint-components/src/components/tax-and-cash/sqm-user-info-form/sqm-user-info-form-view.tsx | Splits isDisabledInput into isDisabledPartnerInput and isDisabledUserInput functions and updates all disabled prop logic throughout the form |
| packages/mint-components/src/components/tax-and-cash/sqm-user-info-form/UserInfoFormView.stories.tsx | Adds new Storybook stories to demonstrate various form states including partner accounts, user accounts, and edge cases |
| packages/mint-components/src/components/sqm-stencilbook/sqm-stencilbook.tsx | Registers the new UserInfoFormView stories in the Stencilbook |
| packages/mint-components/package.json | Bumps version from 2.0.4 to 2.0.5 |
| packages/mint-components/CHANGELOG.md | Documents the bug fix in version 2.0.5 release notes |
Files not reviewed (1)
- packages/mint-components/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...s/mint-components/src/components/tax-and-cash/sqm-user-info-form/sqm-user-info-form-view.tsx
Outdated
Show resolved
Hide resolved
ianhitchcock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its probably best to have Sam review this when he gets back, but I left some feedback
...s/mint-components/src/components/tax-and-cash/sqm-user-info-form/sqm-user-info-form-view.tsx
Outdated
Show resolved
Hide resolved
...s/mint-components/src/components/tax-and-cash/sqm-user-info-form/sqm-user-info-form-view.tsx
Outdated
Show resolved
Hide resolved
...s/mint-components/src/components/tax-and-cash/sqm-user-info-form/sqm-user-info-form-view.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- packages/mint-components/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...s/mint-components/src/components/tax-and-cash/sqm-user-info-form/sqm-user-info-form-view.tsx
Outdated
Show resolved
Hide resolved
.../mint-components/src/components/tax-and-cash/sqm-user-info-form/UserInfoFormView.stories.tsx
Show resolved
Hide resolved
...s/mint-components/src/components/tax-and-cash/sqm-user-info-form/sqm-user-info-form-view.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- packages/mint-components/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../mint-components/src/components/tax-and-cash/sqm-user-info-form/UserInfoFormView.stories.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- packages/mint-components/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description of the change
Fix bug that caused previously unset fields to be disabled
Type of change
Links
Checklists
Development
Paperwork
Code review