Skip to content

Conversation

@noahwc
Copy link
Contributor

@noahwc noahwc commented Nov 26, 2025

Description of the change

Fix bug that caused previously unset fields to be disabled

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copilot AI review requested due to automatic review settings November 26, 2025 21:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where previously unset tax form fields were incorrectly being disabled. The fix refactors the disabled state logic by splitting a single isDisabledInput function into two separate functions: isDisabledPartnerInput (for partner data) and isDisabledUserInput (for user data). This ensures that fields are only disabled when they have actual values, not when they're simply in a user or partner state.

Key Changes:

  • Refactored disabled input logic to properly handle partner vs. user input states
  • Added comprehensive Storybook stories for testing various form states
  • Updated package version to 2.0.5 with changelog entry

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/mint-components/src/components/tax-and-cash/sqm-user-info-form/sqm-user-info-form-view.tsx Splits isDisabledInput into isDisabledPartnerInput and isDisabledUserInput functions and updates all disabled prop logic throughout the form
packages/mint-components/src/components/tax-and-cash/sqm-user-info-form/UserInfoFormView.stories.tsx Adds new Storybook stories to demonstrate various form states including partner accounts, user accounts, and edge cases
packages/mint-components/src/components/sqm-stencilbook/sqm-stencilbook.tsx Registers the new UserInfoFormView stories in the Stencilbook
packages/mint-components/package.json Bumps version from 2.0.4 to 2.0.5
packages/mint-components/CHANGELOG.md Documents the bug fix in version 2.0.5 release notes
Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@noahwc noahwc requested a review from ianhitchcock November 26, 2025 21:56
Copy link
Contributor

@ianhitchcock ianhitchcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its probably best to have Sam review this when he gets back, but I left some feedback

Copilot AI review requested due to automatic review settings November 26, 2025 22:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 29, 2025 01:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings December 1, 2025 18:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ianhitchcock
ianhitchcock previously approved these changes Dec 1, 2025
Copilot AI review requested due to automatic review settings December 2, 2025 17:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@noahwc noahwc merged commit 7df3a7b into master Dec 2, 2025
11 of 14 checks passed
@noahwc noahwc deleted the tax-form-disabled-fields-bug branch December 2, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants