Clarify tests #18
Open
Clarify tests #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tansaku
reviewed
Sep 6, 2018
spec/oracle_of_bacon_spec.rb
Outdated
| it { should match /a=3%252\+%22a/ } | ||
| end | ||
| describe 'service connection', :pending => true do | ||
| describe 'service connection' do |
Contributor
There was a problem hiding this comment.
do we want to remove pending here?
Unclear why when new should not be valid especially when using fake_api_key string as api_key Further review shows that it should not be valid because a person needs to specify a from or a to as default values are the same and therefore not valid as per from_does_not_equal_to method.
mattwr18
force-pushed
the
17_clarify_tests
branch
from
2404b46 to
df4376b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear why when new should not be valid especially when using fake_api_key string as api_key
Further review shows that it should not be valid because a person needs to specify a from or a to
as default values are the same and therefore not valid as per from_does_not_equal_to method.
Fixes #17