Undo checks for existing calibs

[mchiu-bnl]

comment: Undo change to abort if sampmax and ped calibs are missing.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

PR Summary: Undo checks for existing calibrations

Motivation/Context

The MBD (Barrel Barrel Detector) calibration system was previously configured to abort execution if critical calibration files (sampmax and pedestal) were missing from the database or file system. This hard-fail behavior prevented the possibility of calculating these calibrations on the fly during reconstruction, limiting flexibility in data processing workflows.

Key Changes

• Removed early-exit checks in Download_All(): Deleted validation logic that returned error status (-1) when MBD_SAMPMAX or MBD_PED URLs were empty strings
• Relaxed error handling in Download_Ped(): Changed the behavior when pedestal calibration data is not found from returning error status to logging a warning and continuing execution (calibration values remain as NaN)
• Relaxed error handling in Download_SampMax(): Changed the behavior when sampmax calibration data is not found from returning error status to logging a warning and continuing execution (calibration values remain as -1)
• Code size: 14 lines removed from MbdCalib.cc

Reconstruction Behavior Changes

This change enables the calibration system to gracefully handle missing calibrations instead of aborting:

• Missing sampmax and pedestal calibrations no longer halt event processing
• Downstream code can now attempt to calculate these calibrations algorithmically or use default/fallback values
• Diagnostics are still logged (warnings printed) when calibrations are missing
• Code continues with uninitialized/default calibration values (NaN for pedestals, -1 for sampmax)

Potential Risk Areas

• Reconstruction quality: Using default/uncalibrated values could degrade physics reconstruction quality if fallback calculation is not robust
• Diagnostic visibility: Runs without proper calibrations may succeed without explicit failure, requiring careful monitoring of log output to identify calibration issues
• Data consistency: Different data processing chains may produce different results depending on calibration availability
• Performance: If on-the-fly calibration calculation is expensive, performance could be impacted for runs without pre-computed calibrations

Recommendations for Future Work

• Implement robust on-the-fly calibration calculation routines to properly replace missing pre-computed calibrations
• Add verbose logging and quality metrics to track when calibrations are missing vs. used
• Consider adding configuration flags to enforce strict calibration requirements for critical physics analyses

---

Note: AI analysis tools can make mistakes when analyzing diffs. Reviewers should verify the actual impact on calibration logic by examining the complete Download_Ped() and Download_SampMax() implementations and confirming that missing calibrations will not cause downstream crashes or silent physics errors.

[coderabbitai]

📝 Walkthrough

Walkthrough

Removes runtime validation checks in MbdCalib.cc that previously returned error status when required calibration URLs (sampmax_url, ped_url) were absent. The code now continues execution instead of early-failing when these inputs are missing, deferring error handling to downstream operations.

Changes

Cohort / File(s)	Summary
MBD Calibration Error Handling offline/packages/mbd/MbdCalib.cc	Removed early-return guards from Download_All, Download_Ped, and Download_SampMax that previously set _status to -1 and aborted when required calibration sources were unavailable. Code now proceeds with missing inputs instead of failing fast.

Possibly related PRs

• does not try to download sampmax calibs etc for sims #4149: Relocates Download_All execution to real-data-only paths and introduces guarded failure handling in InitRun, modifying the broader calibration download control flow that this PR affects.
• do not abort for missing trms calib #4148: Removes fatal error behavior for missing trms calibration input in the same MbdCalib.cc module, following the same pattern of eliminating hard-fail checks for missing calibration data.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pinkenburg]

merging this now to run this in online production

[sphenix-jenkins-ci]

Build & test report

Report for commit 278cf7399958ccde29102c461c49a212b972a31b:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is FAILURE
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.7331 / 72, and combined p-Value = 0.99837
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = 8.11507e-08 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
    • 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
    • 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
    • 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
    • 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is FAILURE, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration