EpdReco calibration fixes#3816
EpdReco calibration fixes#3816largewedge wants to merge 1 commit intosPHENIX-Collaboration:masterfrom
Conversation
…hanged CDB lookups to use encoded keys instead of channel number, moved cdbttree lookup to InitRun(), and added bad/uncalibrated channel handling.
|
Have you tested these changes against run2auau? Please update your calibration file to use the same structure as previous runs, there is really no need to change things now. Setting a channel to zero artificially based on your fit/calibration factors is dangerous. I would recommend dividing by the average MPV, then use m_TowerInfoContainer_calib->get_tower_at_channel(ch)->set_isNoCalib(true); or other status setters to mark that channel. |
|
Whatever is implemented it has to work across our runs, we don't want separate schemes for run2auau and run3auau. |
|
This PR would break the existing Run2 production and after inserting a reformatted calibration which is compatible with the existing code this PR is not needed anymore |
Build & test reportReport for commit a9a1d929f3f879205bf3af5b3fe4d667502044e1:
Automatically generated by sPHENIX Jenkins continuous integration |
|
These changes were intended to be a short-term fix only to be used for run3 AuAu calibrations. See PR #3828 |



Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
Fixed CDB field lookup name (changed from sepd_calib to mip_calib), changed CDB lookups to use encoded keys instead of channel number, moved cdbttree lookup to InitRun(), and added bad/uncalibrated channel handling.
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)