Fix issue 1364: AID format changes due to new AAVSO upload tool #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed airmass round from 7 to 5 both changes to comply new AAVSO tool
|
@tamimfatahi this is the change I told you about in DM. Please take a look at it. |
|
It seems AAVSO is reverting the changes, I will close this PR from the time being. This is the answer I got in their forum when I asked about the modifications: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1364
changed mag_err from 5 to 4
changed airmass round from 7 to 5
Bot changes are needed because AAVSO is rolling out a new tool to upload photometry data replacing webObs. In that new tool the AID format changed a bit. If we try to upload a current AID file created by Exotic we got the following errors: