Enhance CLI and Action support or options#437
Open
qoomon wants to merge 12 commits into
Open
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
feat: replace positional args in render_svg.ts with named CLI flags
|
@qoomon is attempting to deploy a commit to the ryo-ma's Team Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR upgrades the CLI and GitHub Action interface for generating the SVG trophy card by moving from positional args to named flags and exposing more layout/filter options.
Changes:
- Reworked
render_svg.tsto usestd/flagsparsing with--username/--output/--themeplus layout toggles and filters. - Extended
action.ymlto accept additional inputs (layout, margins, filters) and pass them as flags to the Deno script. - Minor README formatting adjustment to the list of hosted endpoints.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| render_svg.ts | Replace positional CLI args with flag parsing and add validation / filter options. |
| action.yml | Add new action inputs and build a flag-based invocation of render_svg.ts. |
| README.md | Adjust formatting for one endpoint entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changed 'username' input to be optional with a default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.