Messages now display in new version of Ember #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanto
added a commit
that referenced
this pull request
Jun 23, 2014
Messages now display in new version of Ember
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ryan,
This pull request resolves issue #11.
After looking into things on my local machine, it seems like Ember was not faithfully calling the
activate()callback. Instead, I've updated ember-flash-messages to use theenter()callback, which appears to fix everything. I thinkenter()is technically a private method, but it's really just a proxy foractivate()anyways, so I wouldn't be too worried about using it.I wish I could understand exactly what was going on, but I'm having trouble understanding the core Route object.
This PR also includes: