Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages now display in new version of Ember #13

Merged
merged 1 commit into from
Jun 23, 2014
Merged

Conversation

Emerson
Copy link
Collaborator

@Emerson Emerson commented Jun 23, 2014

Hi Ryan,

This pull request resolves issue #11.

After looking into things on my local machine, it seems like Ember was not faithfully calling the activate() callback. Instead, I've updated ember-flash-messages to use the enter() callback, which appears to fix everything. I think enter() is technically a private method, but it's really just a proxy for activate() anyways, so I wouldn't be too worried about using it.

I wish I could understand exactly what was going on, but I'm having trouble understanding the core Route object.

This PR also includes:

  1. Bumping the version of Ember to 1.6.0-beta.5
  2. Bumping the version of handlebars to 1.3
  3. Cleaning and rebuilding the plugin (my last PR did not do that)
  4. Updating the README to reflect the changes in the last PR

ryanto added a commit that referenced this pull request Jun 23, 2014
Messages now display in new version of Ember
@ryanto ryanto merged commit 42eb133 into ryanto:master Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants