Skip to content

Make ObjectId Send + Sync #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2024
Merged

Make ObjectId Send + Sync #500

merged 2 commits into from
Mar 1, 2024

Conversation

scottbot95
Copy link
Contributor

As suggested by @asquared31415 in discord, change the PhantomData on ObjectId<T> from PhantomData<T> to PhantomData<fn() -T>. This is more accurate since ObectId doesn't actually own a T, but it can produce a T.

@scottbot95
Copy link
Contributor Author

Nightly lint seems to be failing for the same reason as #499

@shanemadden shanemadden merged commit 7ca38fd into rustyscreeps:main Mar 1, 2024
@scottbot95 scottbot95 deleted the object-id-send-sync branch March 1, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemadden shanemadden shanemadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottbot95 @shanemadden