Skip to content

feat(init): no install flag #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2018
Merged

feat(init): no install flag #186

merged 3 commits into from
Jun 18, 2018

Conversation

ashleygwilliams
Copy link
Member

fixes #173

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed and have your
    cloned directory set to nightly
$ rustup override set nightly
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran rustfmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@ashleygwilliams ashleygwilliams added this to the 0.4.0 milestone Jun 15, 2018
@ashleygwilliams
Copy link
Member Author

this actually panics rn :/

name = 'wasm-pack'
operating_system = 'unix:OSX'
crate_version = '0.3.1'
explanation = '''
Panic occurred in file 'libcore/option.rs' at line 345
'''
method = 'Panic'
backtrace = '''
stack backtrace:
   0:        0x1030cb524 - backtrace::backtrace::trace::h67a0fd4befda7a08
                        at /Users/ag_dubs/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.8/src/backtrace/mod.rs:42
   1:        0x1030c635c - backtrace::capture::Backtrace::new_unresolved::h08b8ecab3609f75c
                        at /Users/ag_dubs/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.8/src/capture.rs:88
   2:        0x1030c62ae - backtrace::capture::Backtrace::new::hba111deee42de24d
                        at /Users/ag_dubs/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.8/src/capture.rs:63
   3:        0x102ed375a - human_panic::report::Report::new::h228504294fc6e54d
                        at /Users/ag_dubs/.cargo/registry/src/github.com-1ecc6299db9ec823/human-panic-1.0.0/src/report.rs:45
   4:        0x102ed7307 - human_panic::handle_dump::h55a82078bc6de9d9
                        at /Users/ag_dubs/.cargo/registry/src/github.com-1ecc6299db9ec823/human-panic-1.0.0/src/lib.rs:195
   5:        0x102bf20b3 - wasm_pack::main::_$u7b$$u7b$closure$u7d$$u7d$::hefb960ff1f010895
                        at /Users/ag_dubs/rust/wasm-pack/<setup_panic macros>:18
   6:        0x1030fc93e - std::panicking::rust_panic_with_hook::h40a38271bb72dfef
                        at libstd/panicking.rs:515
   7:        0x1030fc6be - std::panicking::continue_panic_fmt::h5130d72fc1ac028e
                        at libstd/panicking.rs:426
   8:        0x1030fc348 - rust_begin_unwind
                        at libstd/panicking.rs:337
   9:        0x10313dce1 - core::panicking::panic_fmt::hb7f8b854a519aab1
                        at libcore/panicking.rs:92
  10:        0x10313dc16 - core::panicking::panic::h0874a63f21049da1
                        at libcore/panicking.rs:53
  11:        0x102dd4ae9 - _$LT$core..option..Option$LT$T$GT$$GT$::unwrap::h522a802bf073404e
                        at /Users/travis/build/rust-lang/rust/src/libcore/macros.rs:20
  12:        0x102c496ce - wasm_pack::command::init::Init::step_run_wasm_bindgen::hf0462a92013469ec
                        at src/command/init.rs:227
  13:        0x102c4636f - wasm_pack::command::init::Init::process::h1ae2cac26abc03f0
                        at src/command/init.rs:104
  14:        0x102c6f75f - wasm_pack::command::run_wasm_pack::hae2da31092a5e1b5
                        at src/command/mod.rs:114
  15:        0x102bf3ee7 - wasm_pack::run::h3d56ae319c0e5fbe
                        at src/main.rs:25
  16:        0x102bf362b - wasm_pack::main::hcb1ee59845757acf
                        at src/main.rs:13
  17:        0x102bf4011 - std::rt::lang_start::_$u7b$$u7b$closure$u7d$$u7d$::h18fc6d340a45a94d
                        at /Users/travis/build/rust-lang/rust/src/libstd/rt.rs:74
  18:        0x1030fc2c7 - std::panicking::try::do_call::h5aaa5bbee6b5b129
                        at libstd/panicking.rs:310
  19:        0x10310895e - __rust_maybe_catch_panic
                        at libpanic_unwind/lib.rs:105
  20:        0x1030ee801 - std::rt::lang_start_internal::h8b84524b7083c7ad
                        at libstd/panicking.rs:289
  21:        0x102bf3ff1 - std::rt::lang_start::hc7f1b61362fa4fe8
                        at /Users/travis/build/rust-lang/rust/src/libstd/rt.rs:74
  22:        0x102bf3f94 - main'''

@mgattozzi
Copy link
Contributor

oof let me take a look

@mgattozzi
Copy link
Contributor

Okay I also definitely got the panic

@mgattozzi
Copy link
Contributor

Well I have had night with my yubikey so I'm going to email you the patch file, but also amazing branch name now that the patch file showed it to me.

@ashleygwilliams
Copy link
Member Author

applying patch from email- looks like it fixes the panic so i'mma review and then likely merge

@ashleygwilliams ashleygwilliams merged commit 48410ba into master Jun 18, 2018
@ashleygwilliams ashleygwilliams deleted the no-install-no-cry branch June 18, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--no-install flag
2 participants