Skip to content

HBOF in toodee DrainCol destructor #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions crates/toodee/RUSTSEC-0000-0000.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "toodee"
date = "2025-05-22"

url = "https://github.com/antonmarsden/toodee/issues/26"
categories = ["memory-corruption", "memory-exposure"]
keywords = ["memory-safety", "buffer-overflow"]

[versions]
patched = [">= 0.6.0"]
unaffected = ["< 0.2.0"]

[affected.functions]
"toodee::DrainCol::drop" = [">= 0.2.0, <= 0.5.0"]
```

# Heap Buffer Overflow in the DrainCol Destructor

An off-by-one error in the `DrainCol::drop` destructor could cause an unsafe memory copy
operation to exceed the bounds of the associated vector.

The error was related to the size of the data being copied in one of the `ptr::copy`
invocations inside the destructor.

When removing the first column from a TooDee object, the DrainCol return object could cause
a heap buffer overflow vulnerability when it is dropped.

The issue was fixed in commit `e6e16d5` by reducing the copied size by one.