-
Notifications
You must be signed in to change notification settings - Fork 416
Add advisory for unsound problems in workflow-core
#2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Still unsound in 0.18.0. Could you update the version in the advisory? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The report is technically accurate.
Sadly, there's no fixed version, and it looks like development on the crate has ground to a halt.
|
Thanks for all |
|
@aspect @surinder83singh can you talk about the maintenance status of the workflow-core crate? If it's unmaintained, it would be good to communicate this. |
|
Thanks for tagging. This is great. No, the crate is very much maintained and is critical to some well maintained mainstream applications. This is my fault as I have basically disregarded this assuming that this is AI auto-detection and this crate contains general-purpose toolbox of different handy utils ... not really used by anyone (and apparently broken :)). They just sit in one of the submodules. I am unfortunately swamped and can't look at this right now or in the coming days. There is a maintenance pass that is needed in related crates (it's a large framework). These functions should be just killed off. I will add this to my general todo list and address this eventually. |
|
@aspect okay, so is it okay if we just publish this advisory without fixed versions for now? We can always add those later as they become available. |
The util functions
buffer_as_sliceandbuffer_as_slice_mutin crateworkflow-corecould create illegal slice.The details are described in workflow-rs/workflow-rs#11