Eagerly build root store on miscellaneous Unix platforms #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
eager-verifier
branch
9 times, most recently
from
3bed7df to
7c24d86
Compare
ctz
approved these changes
Apr 28, 2025
djc
force-pushed
the
eager-verifier
branch
2 times, most recently
from
394fdf9 to
73d99b4
Compare
|
Is there some larger context/motivation that can be called out in the PR desc? |
Yes, done. |
djc
force-pushed
the
eager-verifier
branch
2 times, most recently
from
f5d22a6 to
b16ce14
Compare
djc
commented
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust-lang/rustup#4305 we found that errors due to not being able to find platform roots (on Fedora) were being silently ignored partly due to the lazy loading of roots in the
others::Verifierused on Linux and other non-darwin/Android Unices. @complexspaces worked around the immediate issue in #169, but there doesn't seem to be a clear motivation for lazy-loading, and simplifying it has the additional benefit of removing the need for the once_cell dependency on most platforms.