-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally push benchmark results to bencher.dev #6
Conversation
ci-bench-runner/src/bencher_dev.rs
Outdated
} | ||
|
||
/// Sends the instruction counts to bencher.dev for visualization | ||
pub async fn send_icounts_to_bencher( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this a method for BencherDev
?
Yup! Because of the We can fix the vendoring hashes for the git dependency, but I run into problems building Flake update for the cargoLock outputHashes:39c39,49
< cargoLock = { lockFile = "${crateDir}/Cargo.lock"; };
---
> cargoLock = {
> lockFile = "${crateDir}/Cargo.lock";
> outputHashes = {
> "bencher_client-0.3.15" =
> "sha256-VWCQvcszAkny0VANH0o4FoIhe+6w0MgBJveWum44wS4=";
> "progenitor-0.4.0" =
> "sha256-XbZ0ioirI4sYYGyyhstNXEs2v3azlT5z8YE6Fyl3uB4=";
> "typify-0.0.14" =
> "sha256-PYX6I0qBTrCeRK6zMFxqwaRUvIrx9md7kGz+nRo/jIo=";
> };
> }; bencher_client build err:
I think given the way this repo is being used we should remove the package derivation and just use Nix to manage the dev. environment. The package isn't very useful right now since the Ansible deployment isn't going to use it (it builds from src on the host). It probably isn't worth debugging this too deeply - we can merge as is and I'll remove the package from the flake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
ansible/readme.md
Outdated
@@ -67,12 +67,14 @@ Before starting, you will need: | |||
* A GitHub application configured according to the [GitHub app](../readme.md#github-app) section of | |||
the main README. The application **must** be installed on your fork of the rustls repo, with the required | |||
permissions. | |||
* If testing code changes to the `ci-bench-runner` app or Ansbile playbooks, a fork of this repository that | |||
* (Optional) A Bencher.dev project and testbed, configured according to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* (Optional) A Bencher.dev project and testbed, configured according to the | |
* (Optional) A [Bencher.dev](https://bencher.dev/) project and testbed, configured according to the |
Here's a small patch for that: #7 No docs updates required, we only described the dev env in README. |
Co-authored-by: Everett Pompeii <[email protected]>
Supersedes #4
Thanks @epompeii for the initial implementation!
@cpu do we need to adjust the flake file regarding the new git dependency? I tested
nix develop
followed bycargo check
and it worked, so maybe no changes are necessary.