Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench_pr: track switch to callgrind/callgrind_annotate #36

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 20, 2024

I haven't chased all the "cachegrind" instances down, since they appear in URLs and it feels a bit excessive to change those?

See sample output: rustls/rustls#2122 (comment)

890726a is the current deployed version; I will do another deploy post-merge so that the deployed version is the tip of main.

@ctz ctz marked this pull request as draft September 20, 2024 17:16
@ctz ctz marked this pull request as ready for review September 23, 2024 10:17
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ctz ctz merged commit be2f111 into main Sep 23, 2024
9 checks passed
@ctz
Copy link
Member Author

ctz commented Sep 23, 2024

$ curl https://bench.rustls.dev/info
{"active_job_id":null,"event_processing_enabled":true,"git_commit_message":"bench_pr: track switch to callgrind/callgrind_annotate","git_commit_sha":"be2f1115a8a580dc24f95ea28c770bc7bc8534c5"}

@cpu cpu deleted the jbp-callgrind branch September 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants