fix: replace vergen by directly running git
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aochagavia
force-pushed
the
info-take-2
branch
from
b7522d2 to
6b79d3a
Compare
For some reason, `vergen` was unable to find the git binary when building inside Ansible. Running git directly fixes the problem... and we also have one dependency less! 🎉
aochagavia
force-pushed
the
info-take-2
branch
from
6b79d3a to
7582704
Compare
|
I'm puzzled to see that the solution was so simple... I guess I should be more skeptical of dependencies in the future, instead of blaming ansible 😅. Merging right away since we already discussed this. |
cpu
reviewed
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
vergenwas unable to find the git binary when building inside Ansible. Running git directly fixes the problem... and we also have one dependency less! 🎉Fixes #27