Forwards compatible Bencher Client #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epompeii
force-pushed
the
future_proof
branch
2 times, most recently
from
b3868a8 to
d91aefa
Compare
epompeii
force-pushed
the
future_proof
branch
from
d91aefa to
217f566
Compare
|
Thanks! The CI failure is unrelated (I locally checked that everything works). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After submitting the last PR to update the Bencher Client (#18) this got me thinking about how to avoid/limit having to do so in the future.
The format for creating a Report is stable and shouldn't experience any breaking changes. However, the reason for the last PR and likely more in the future is the format for the generated Report. So I created a new, forwards compatible API call
sendthat doesn't do strict response schema validation.So hopefully this is the last PR for a while 😃