Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase tokio timeout to fix flakiness #10

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Increase tokio timeout to fix flakiness #10

merged 1 commit into from
Nov 8, 2023

Conversation

aochagavia
Copy link
Collaborator

@aochagavia aochagavia commented Nov 8, 2023 •
edited
Loading

Fixes #9 (hopefully)

cpu
cpu approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slapped together a commit that runs the cargo tests repeatedly in CI. Without this fix it was pretty easy to get CI to fail. With this fix I haven't seen it fail once.

Thanks!

@aochagavia aochagavia merged commit a2f90b8 into main Nov 8, 2023
9 checks passed
@aochagavia aochagavia deleted the fix-flakiness branch November 8, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_pr_opened_happy_path_with_failed_comment_reuse flaky?
2 participants
@aochagavia @cpu