-
Notifications
You must be signed in to change notification settings - Fork 122
Updated .gitignore
to be more specific
#342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a little bit overkill, but seems harmless :-) Thanks!
I'd prefer something smaller/more focused. Do you have an actual file that you need ignored in your own setup? |
Yes, I'm building on MacOS with VSCode (and have used Rust Rover in the past). So there are a few files / directories I like to mask out for git. |
Okay, can you get rid of the three-line section headers and trim this to just the stuff that you have a direct/short-term need for? |
893f765
to
55cfe2a
Compare
.gitignore
Outdated
/target | ||
|
||
# Secret | ||
certs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can you add a trailing newline?
I don't think we should be adding such extensive changes. editor specific files, backup files, etc should go into the user-local gitignore, not into each project's gitignore. project gitignores should get stuff that is either specific to the language/technology (like build artifact dir) or to the individual project (say a dir for generated certificates, if the tool generates certificates). |
From https://git-scm.com/docs/gitignore
Note that in the past I've also done this extend gitignore game, but eventually I realized that user-specific gitignores are better for editor specific stuff. |
@est31, can you specify what items you would like to update / remove? Following your strategy, the original file would also remove the |
yeah probably we should also remove |
@est31, I'll return the |
55cfe2a
to
90c3975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for filing!
Hi, I want to improve the
rcgen
crate and noticed that certain items were not included into the.gitignore
. So I thought updating this file would be a great start of introducing myself and start working on the project (if you would have me). 😄