-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add openharmony platform preset certs folder #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Doesn't OpenHarmony have its own |
No.. only |
I guess if that makes all the Please rebase on top of current |
|
(Please rebase and squash all your changes into a single commit.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me, let's see what other folks think.
cpu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping, apologies for letting this sit. The diff looks OK to me.
| "/etc/pki/tls/cacert.pem", // OpenELEC (a media center Linux distro) | ||
| "/etc/ssl/cert.pem", // Alpine Linux | ||
| "/opt/etc/ssl/certs/ca-certificates.crt", // Entware, https://github.com/rustls/openssl-probe/pull/21 | ||
| "/etc/ssl/certs/cacert.pem", // OpenHarmony, https://developer.huawei.com/consumer/cn/doc/harmonyos-faqs/faqs-network-41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we use the en translation of this page:
| "/etc/ssl/certs/cacert.pem", // OpenHarmony, https://developer.huawei.com/consumer/cn/doc/harmonyos-faqs/faqs-network-41 | |
| "/etc/ssl/certs/cacert.pem", // OpenHarmony, https://developer.huawei.com/consumer/en/doc/harmonyos-faqs/faqs-network-41 |
follow #38 cc @djc
Also fix #29