Deprecate env-var-writing functions #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace them with `unsafe` equivalents with documentation indicating that you probably shouldn't rely on them. Not the best solution but given the age of this crate there's not really a whole lot else that can be done. Closes #30
eaufavor
reviewed
Jan 23, 2025
|
|
||
| /// Deprecated as this isn't sound, use [`init_openssl_env_vars`] instead. | ||
| #[doc(hidden)] | ||
| #[deprecated(note = "this function is not safe, use `init_openssl_env_vars` instead")] |
There was a problem hiding this comment.
Nitpicking about the message: it reads like "this function is unsafe, so please use the safe version, init_openssl_env_vars".
In reality what it means to say is "This function is not correctly marked as unsafe, use the correct version, init_openssl_env_vars, instead"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace them with
unsafeequivalents with documentation indicating that you probably shouldn't rely on them. Not the best solution but given the age of this crate there's not really a whole lot else that can be done.Closes #30