-
-
Notifications
You must be signed in to change notification settings - Fork 12
refactor(setup): move setup_*
helpers to a separate module
#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f620b4a
to
88d9f29
Compare
88d9f29
to
4ec55cb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 24.74% 28.76% +4.01%
==========================================
Files 6 8 +2
Lines 1265 970 -295
==========================================
- Hits 313 279 -34
+ Misses 952 691 -261 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ec55cb
to
0d93d01
Compare
The commit history here doesn't currently seem to make much sense. The first commit seems to make stylistic changes and adds a bunch of new code (with bullet points in the commit message, suggesting that there are things that could be separate commits), and the second commit only removing a bunch of code (which apparently has become useless -- if that was caused by the first commit, it should be in the same commit). |
0d93d01
to
17faf08
Compare
setup_*
helpers to a separate modude
While libc is upgraded to 0.2.175, |
Okay, this still looks like very far from what I consider to be commits that are easy to review. I'm going to give up on reviewing this PR. |
17faf08
to
47cbd3a
Compare
setup_*
helpers to a separate modudesetup_*
helpers to a separate module
refactor(ffi): `ffi::CryptoInfo` is renamed to `ffi::TlsCryptoInfo`, and no longer exported
47cbd3a
to
219e0f0
Compare
Part of #62
Breaking changes:
TlsCryptoInfo
(formerlyCryptoInfo
)config_ktls_*
now requires the socket implementsAsFd
.