Skip to content

Conversation

@cxw620
Copy link
Contributor

@cxw620 cxw620 commented Sep 3, 2025

This PR adds rustfmt config and formats the codes, making it easier to merge later commits.


Part of #62.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much more reviewable, thanks!

Suggest getting rid of the "PR62: partial" prefixes on commit messages which are pretty useless and crowd out the actual content of the messages.

@djc
Copy link
Member

djc commented Sep 3, 2025

Breaking changes: explicitly set rust-edition to 2021.

That should be in a separate commit.

@cxw620 cxw620 force-pushed the use-rustls-kernel-connection-0 branch from 8cc482b to 546eac0 Compare September 3, 2025 07:32
@cxw620
Copy link
Contributor Author

cxw620 commented Sep 3, 2025

Breaking changes: explicitly set rust-edition to 2021.

That should be in a separate commit.

My mistake, Rust edition has been already set to 2021, I didn't change it.

@cxw620 cxw620 force-pushed the use-rustls-kernel-connection-0 branch from 546eac0 to 8883888 Compare September 3, 2025 07:41
@cxw620 cxw620 marked this pull request as ready for review September 3, 2025 07:42
@cxw620 cxw620 force-pushed the use-rustls-kernel-connection-0 branch from 8883888 to 9731f30 Compare September 3, 2025 08:32
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks for the iterations!

@cxw620
Copy link
Contributor Author

cxw620 commented Sep 3, 2025

For formatting, I think we can take rustls as an example, splitting stable and unstable config and add CI like this?

https://github.com/rustls/rustls/blob/a84d3e47388f0aa57ed96a81d4f85a46ffdab439/.github/workflows/build.yml#L429-L448

Shall this be done in a separate PR or here? I think we need to sort the import and modules.

@djc
Copy link
Member

djc commented Sep 3, 2025

For formatting, I think we can take rustls as an example, splitting stable and unstable config and add CI like this?

https://github.com/rustls/rustls/blob/a84d3e47388f0aa57ed96a81d4f85a46ffdab439/.github/workflows/build.yml#L429-L448

This shall be done in a separate PR. I think we need to sort the import and modules.

Sounds okay to me. Given that this is a much smaller crate, I think it would also be fine to drop the unstable config + CI for now and just do an initial pass to use StdExternalCrate imports by hand.

@cxw620 cxw620 force-pushed the use-rustls-kernel-connection-0 branch from 9731f30 to 7d9d5cc Compare September 3, 2025 08:49
@cxw620 cxw620 mentioned this pull request Sep 3, 2025
@djc djc added this pull request to the merge queue Sep 3, 2025
Merged via the queue into rustls:main with commit e159023 Sep 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants