-
-
Notifications
You must be signed in to change notification settings - Fork 12
Updates repo metadata and formats the codes (part of #62) #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much more reviewable, thanks!
Suggest getting rid of the "PR62: partial" prefixes on commit messages which are pretty useless and crowd out the actual content of the messages.
That should be in a separate commit. |
8cc482b to
546eac0
Compare
My mistake, Rust |
546eac0 to
8883888
Compare
8883888 to
9731f30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thanks for the iterations!
|
For formatting, I think we can take rustls as an example, splitting stable and unstable config and add CI like this? Shall this be done in a separate PR or here? I think we need to sort the import and modules. |
Sounds okay to me. Given that this is a much smaller crate, I think it would also be fine to drop the unstable config + CI for now and just do an initial pass to use |
9731f30 to
7d9d5cc
Compare
This PR adds
rustfmtconfig and formats the codes, making it easier to merge later commits.Part of #62.