Skip to content

Made server example tls_acceptor comment more clear #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Made server example tls_acceptor comment more clear #114

wants to merge 1 commit into from

Conversation

jspspike
Copy link

@jspspike jspspike commented Aug 7, 2020

Previous comment would not prevent server abort. Changed to use filter_map and updated comment.

cpu
cpu approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable improvement to me and perhaps a better alternative to #98. @djc WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspspike @cpu